Improve file filtering during bundle packing

# Conflicts:
#	package.json
#	src/bundle.js

package.json

@@ -1,6 +1,6 @@
 {
   "name": "react-native-update-cli",
-  "version": "1.38.2",
+  "version": "1.39.2",
   "description": "Command tools for javaScript updater with `pushy` service for react native apps.",
   "main": "index.js",
   "bin": {

src/bundle.ts

@@ -3,7 +3,7 @@ import { getRNVersion, translateOptions } from './utils';
 import * as fs from 'fs-extra';
 import { ZipFile } from 'yazl';
 import { open as openZipFile } from 'yauzl';
-import { question, printVersionCommand } from './utils';
+import { question, checkPlugins } from './utils';
 import { checkPlatform } from './app';
 import { spawn, spawnSync } from 'node:child_process';
 import semverSatisfies from 'semver/functions/satisfies';
@@ -22,16 +22,20 @@ try {
   hdiff = require('node-hdiffpatch').diff;
 } catch (e) {}
 
+
 async function runReactNativeBundleCommand(
-  bundleName,
-  development,
-  entryFile,
-  outputFolder,
-  platform,
-  sourcemapOutput,
-  config,
+  bundleName: string,
+  development: string,
+  entryFile: string,
+  outputFolder: string,
+  platform: string,
+  sourcemapOutput: string,
+  config: string,
 ) {
-  let gradleConfig = {};
+  let gradleConfig: {
+    crunchPngs?: boolean;
+    enableHermes?: boolean;
+  } = {};
   if (platform === 'android') {
     gradleConfig = await checkGradleConfig();
     if (gradleConfig.crunchPngs !== false) {
@@ -41,7 +45,7 @@ async function runReactNativeBundleCommand(
     }
   }
 
-  const reactNativeBundleArgs = [];
+  const reactNativeBundleArgs: string[] = [];
 
   const envArgs = process.env.PUSHY_ENV_ARGS;
 
@@ -86,6 +90,8 @@ async function runReactNativeBundleCommand(
       });
     }
   }
+  const bundleParams = await checkPlugins();
+  const isSentry = bundleParams.sentry;
   const bundleCommand = usingExpo
     ? 'export:embed'
     : platform === 'harmony'
@@ -156,17 +162,17 @@ async function runReactNativeBundleCommand(
           ),
         );
       } else {
-        let hermesEnabled = false;
+        let hermesEnabled: boolean | undefined = false;
 
         if (platform === 'android') {
-          const gradlePropeties = await new Promise((resolve) => {
+          const gradlePropeties = await new Promise<{ hermesEnabled?: boolean }>((resolve) => {
             properties.parse(
               './android/gradle.properties',
               { path: true },
-              (error, props) => {
+              (error: any, props: { hermesEnabled?: boolean }) => {
                 if (error) {
                   console.error(error);
-                  resolve(null);
+                  resolve({});
                 }
 
                 resolve(props);
@@ -190,6 +196,7 @@ async function runReactNativeBundleCommand(
             bundleName,
             outputFolder,
             sourcemapOutput,
+            !isSentry,
           );
         }
         resolve(null);
@@ -198,7 +205,7 @@ async function runReactNativeBundleCommand(
   });
 }
 
-async function copyHarmonyBundle(outputFolder) {
+async function copyHarmonyBundle(outputFolder: string) {
   const harmonyRawPath = 'harmony/entry/src/main/resources/rawfile';
   try {
     await fs.ensureDir(harmonyRawPath);
@@ -212,7 +219,7 @@ async function copyHarmonyBundle(outputFolder) {
 
     await fs.ensureDir(outputFolder);
     await fs.copy(harmonyRawPath, outputFolder);
-  } catch (error) {
+  } catch (error: any) {
     console.error('copyHarmonyBundle 错误:', error);
     throw new Error(`复制文件失败: ${error.message}`);
   }
@@ -250,9 +257,10 @@ async function checkGradleConfig() {
 }
 
 async function compileHermesByteCode(
-  bundleName,
-  outputFolder,
-  sourcemapOutput,
+  bundleName: string,
+  outputFolder: string,
+  sourcemapOutput: string,
+  shouldCleanSourcemap: boolean,
 ) {
   console.log('Hermes enabled, now compiling to hermes bytecode:\n');
   // >= rn 0.69
@@ -309,22 +317,113 @@ async function compileHermesByteCode(
       },
     );
   }
+  if (shouldCleanSourcemap) {
+    fs.removeSync(path.join(outputFolder, `${bundleName}.txt.map`));
+  }
+}
+
+async function copyDebugidForSentry(bundleName: string, outputFolder: string, sourcemapOutput: string) {
+  if (sourcemapOutput) {
+    let copyDebugidPath;
+    try {
+      copyDebugidPath = require.resolve(
+        '@sentry/react-native/scripts/copy-debugid.js',
+        {
+          paths: [process.cwd()],
+        },
+      );
+    } catch (error) {
+      console.error(
+        '无法找到 Sentry copy-debugid.js 脚本文件，请确保已正确安装 @sentry/react-native',
+      );
+      return;
+    }
+
+    if (!fs.existsSync(copyDebugidPath)) {
+      return;
+    }
+    console.log('Copying debugid');
+    spawnSync(
+      'node',
+      [
+        copyDebugidPath,
+        path.join(outputFolder, `${bundleName}.txt.map`),
+        path.join(outputFolder, `${bundleName}.map`),
+      ],
+      {
+        stdio: 'ignore',
+      },
+    );
+  }
   fs.removeSync(path.join(outputFolder, `${bundleName}.txt.map`));
 }
 
-async function pack(dir, output) {
+async function uploadSourcemapForSentry(
+  bundleName: string,
+  outputFolder: string,
+  sourcemapOutput: string,
+  version: string,
+) {
+  if (sourcemapOutput) {
+    let sentryCliPath;
+    try {
+      sentryCliPath = require.resolve('@sentry/cli/bin/sentry-cli', {
+        paths: [process.cwd()],
+      });
+    } catch (error) {
+      console.error('无法找到 Sentry CLI 工具，请确保已正确安装 @sentry/cli');
+      return;
+    }
+
+    if (!fs.existsSync(sentryCliPath)) {
+      return;
+    }
+
+    spawnSync(
+      'node',
+      [sentryCliPath, 'releases', 'set-commits', version, '--auto'],
+      {
+        stdio: 'inherit',
+      },
+    );
+    console.log(`Sentry release created for version: ${version}`);
+
+    console.log('Uploading sourcemap');
+    spawnSync(
+      'node',
+      [
+        sentryCliPath,
+        'releases',
+        'files',
+        version,
+        'upload-sourcemaps',
+        '--strip-prefix',
+        path.join(process.cwd(), outputFolder),
+        path.join(outputFolder, bundleName),
+        path.join(outputFolder, `${bundleName}.map`),
+      ],
+      {
+        stdio: 'inherit',
+      },
+    );
+  }
+}
+
+const ignorePackingFileNames = ['.', '..', 'index.bundlejs.map'];
+const ignorePackingExtensions = ['DS_Store'];
+async function pack(dir: string, output: string) {
   console.log('Packing');
   fs.ensureDirSync(path.dirname(output));
-  await new Promise((resolve, reject) => {
+  await new Promise<void>((resolve, reject) => {
     const zipfile = new ZipFile();
 
-    function addDirectory(root, rel) {
+    function addDirectory(root: string, rel: string) {
       if (rel) {
         zipfile.addEmptyDirectory(rel);
       }
       const childs = fs.readdirSync(root);
       for (const name of childs) {
-        if (name === '.' || name === '..' || name === 'index.bundlejs.map') {
+        if (ignorePackingFileNames.includes(name) || ignorePackingExtensions.some(ext => name.endsWith(`.${ext}`))) {
           continue;
         }
         const fullPath = path.join(root, name);
@@ -341,7 +440,7 @@ async function pack(dir, output) {
 
     addDirectory(dir, '');
 
-    zipfile.outputStream.on('error', (err) => reject(err));
+    zipfile.outputStream.on('error', (err: any) => reject(err));
     zipfile.outputStream.pipe(fs.createWriteStream(output)).on('close', () => {
       resolve();
     });
@@ -350,12 +449,12 @@ async function pack(dir, output) {
   console.log(`ppk热更包已生成并保存到: ${output}`);
 }
 
-export function readEntire(entry, zipFile) {
-  const buffers = [];
+export function readEntire(entry: string, zipFile: ZipFile) {
+  const buffers: Buffer[] = [];
   return new Promise((resolve, reject) => {
-    zipFile.openReadStream(entry, (err, stream) => {
+    zipFile.openReadStream(entry, (err: any, stream: any) => {
       stream.pipe({
-        write(chunk) {
+        write(chunk: Buffer) {
           buffers.push(chunk);
         },
         end() {
@@ -370,12 +469,12 @@ export function readEntire(entry, zipFile) {
   });
 }
 
-function basename(fn) {
+function basename(fn: string) {
   const m = /^(.+\/)[^\/]+\/?$/.exec(fn);
   return m?.[1];
 }
 
-async function diffFromPPK(origin, next, output) {
+async function diffFromPPK(origin: string, next: string, output: string) {
   fs.ensureDirSync(path.dirname(output));
 
   const originEntries = {};
@@ -420,7 +519,7 @@ async function diffFromPPK(origin, next, output) {
 
   const addedEntry = {};
 
-  function addEntry(fn) {
+  function addEntry(fn: string) {
     //console.log(fn);
     if (!fn || addedEntry[fn]) {
       return;
@@ -517,11 +616,11 @@ async function diffFromPPK(origin, next, output) {
 }
 
 async function diffFromPackage(
-  origin,
-  next,
-  output,
-  originBundleName,
-  transformPackagePath = (v) => v,
+  origin: string,
+  next: string,
+  output: string,
+  originBundleName: string,
+  transformPackagePath = (v: string) => v,
 ) {
   fs.ensureDirSync(path.dirname(output));
 
@@ -530,7 +629,7 @@ async function diffFromPackage(
 
   let originSource;
 
-  await enumZipEntries(origin, (entry, zipFile) => {
+  await enumZipEntries(origin, (entry: any, zipFile: any) => {
     if (!/\/$/.test(entry.fileName)) {
       const fn = transformPackagePath(entry.fileName);
       if (!fn) {
@@ -624,9 +723,9 @@ async function diffFromPackage(
   await writePromise;
 }
 
-export async function enumZipEntries(zipFn, callback, nestedPath = '') {
+export async function enumZipEntries(zipFn: string, callback: (entry: any, zipFile: any) => void, nestedPath = '') {
   return new Promise((resolve, reject) => {
-    openZipFile(zipFn, { lazyEntries: true }, async (err, zipfile) => {
+    openZipFile(zipFn, { lazyEntries: true }, async (err: any, zipfile: ZipFile) => {
       if (err) {
         return reject(err);
       }
@@ -724,6 +823,10 @@ export const commands = {
         platform,
       });
 
+    const bundleParams = await checkPlugins();
+    const sourcemapPlugin = bundleParams.sourcemap;
+    const isSentry = bundleParams.sentry;
+
     const sourcemapOutput = path.join(intermediaDir, `${bundleName}.map`);
 
     const realOutput = output.replace(/\$\{time\}/g, `${Date.now()}`);
@@ -742,19 +845,28 @@ export const commands = {
       entryFile,
       intermediaDir,
       platform,
-      sourcemap ? sourcemapOutput : '',
+      sourcemap || sourcemapPlugin ? sourcemapOutput : '',
     );
 
     await pack(path.resolve(intermediaDir), realOutput);
 
     const v = await question('是否现在上传此热更包?(Y/N)');
     if (v.toLowerCase() === 'y') {
-      await this.publish({
+    const versionName = await this.publish({
         args: [realOutput],
         options: {
           platform,
         },
       });
+      if (isSentry) {
+        await copyDebugidForSentry(bundleName, intermediaDir, sourcemapOutput);
+        await uploadSourcemapForSentry(
+          bundleName,
+          intermediaDir,
+          sourcemapOutput,
+          versionName,
+        );
+      }
     }
   },
 

src/utils/check-plugin.ts

@@ -0,0 +1,28 @@
+import { plugins } from './plugin-config';
+
+interface BundleParams {
+  sentry: boolean;
+  sourcemap: boolean;
+  [key: string]: any;
+}
+
+export async function checkPlugins(): Promise<BundleParams> {
+  const params: BundleParams = {
+    sentry: false,
+    sourcemap: false,
+  };
+
+  for (const plugin of plugins) {
+    try {
+      const isEnabled = await plugin.detect();
+      if (isEnabled && plugin.bundleParams) {
+        Object.assign(params, plugin.bundleParams);
+        console.log(`检测到 ${plugin.name} 插件,应用相应打包配置`);
+      }
+    } catch (err) {
+      console.warn(`检测 ${plugin.name} 插件时出错:`, err);
+    }
+  }
+
+  return params;
+}

src/utils/index.ts

@@ -6,6 +6,7 @@ import AppInfoParser from './app-info-parser';
 import semverSatisfies from 'semver/functions/satisfies';
 import chalk from 'chalk';
 import latestVersion from '@badisi/latest-version';
+import { checkPlugins } from './check-plugin';
 
 import { read } from 'read';
 
@@ -225,3 +226,5 @@ export async function printVersionCommand() {
 }
 
 export const pricingPageUrl = 'https://pushy.reactnative.cn/pricing.html';
+
+export { checkPlugins };

src/utils/plugin-config.ts

@@ -0,0 +1,32 @@
+import fs from 'fs-extra';
+
+interface PluginConfig {
+  name: string;
+  bundleParams?: {
+    [key: string]: any;
+  };
+  detect: () => Promise<boolean>;
+}
+
+export const plugins: PluginConfig[] = [
+  {
+    name: 'sentry',
+    bundleParams: {
+      sentry: true,
+      sourcemap: true,
+    },
+    detect: async () => {
+      try {
+        await fs.access('ios/sentry.properties');
+        return true;
+      } catch {
+        try {
+          await fs.access('android/sentry.properties');
+          return true;
+        } catch {
+          return false;
+        }
+      }
+    }
+  }
+];

src/versions.js

@@ -97,8 +97,9 @@ export const commands = {
 
     const { hash } = await uploadFile(fn);
 
+    const versionName = name || (await question('输入版本名称: ')) || '(未命名)';
     const { id } = await post(`/app/${appId}/version/create`, {
-      name: name || (await question('输入版本名称: ')) || '(未命名)',
+      name: versionName,
       hash,
       description: description || (await question('输入版本描述:')),
       metaInfo: metaInfo || (await question('输入自定义的 meta info:')),
@@ -111,6 +112,7 @@ export const commands = {
     if (v.toLowerCase() === 'y') {
       await this.update({ args: [], options: { versionId: id, platform } });
     }
+    return versionName;
   },
   versions: async ({ options }) => {
     const platform = checkPlatform(