v1.20.0

LICENSE

@@ -1,29 +0,0 @@
-BSD 3-Clause License
-
-Copyright (c) 2020, reactnativecn
-All rights reserved.
-
-Redistribution and use in source and binary forms, with or without
-modification, are permitted provided that the following conditions are met:
-
-1. Redistributions of source code must retain the above copyright notice, this
-   list of conditions and the following disclaimer.
-
-2. Redistributions in binary form must reproduce the above copyright notice,
-   this list of conditions and the following disclaimer in the documentation
-   and/or other materials provided with the distribution.
-
-3. Neither the name of the copyright holder nor the names of its
-   contributors may be used to endorse or promote products derived from
-   this software without specific prior written permission.
-
-THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
-AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
-IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
-DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE
-FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
-DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
-SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
-CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
-OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
-OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

cli.json

@@ -80,6 +80,33 @@
         },
         "packageId": {
           "hasValue": true
+        },
+
+        "packageVersion": {
+          "hasValue": true
+        }
+      }
+    },
+
+    "updateVersionInfo": {
+      "options": {
+        "platform": {
+          "hasValue": true
+        },
+        "versionId": {
+          "hasValue": true
+        },
+        "name": {
+          "default": false,
+          "hasValue": true
+        },
+        "description": {
+          "default": false,
+          "hasValue": true
+        },
+        "metaInfo": {
+          "default": false,
+          "hasValue": true
         }
       }
     },
@@ -113,7 +140,9 @@
           "default": ".pushy/output/${platform}.${time}.ppk",
           "hasValue": true
         },
-        "verbose": {}
+        "sourcemap": {
+          "default": false
+        }
       }
     },
     "release": {

package.json

@@ -1,6 +1,6 @@
 {
   "name": "react-native-update-cli",
-  "version": "1.4.0",
+  "version": "1.20.0",
   "description": "Command tools for javaScript updater with `pushy` service for react native apps.",
   "main": "index.js",
   "bin": {
@@ -12,7 +12,6 @@
     "cli.json"
   ],
   "scripts": {
-    "test": "echo \"Error: no test specified\" && exit 1",
     "prepublish": "babel src --out-dir lib"
   },
   "repository": {
@@ -32,18 +31,19 @@
   },
   "homepage": "https://github.com/reactnativecn/react-native-pushy/tree/master/react-native-pushy-cli",
   "dependencies": {
-    "app-info-parser": "^1.0.0",
+    "app-info-parser": "^1.1.6",
     "cli-arguments": "^0.2.1",
     "filesize-parser": "^1.5.0",
     "fs-extra": "8",
-    "gradle-to-js": "^2.0.0",
+    "gradle-to-js": "^2.0.1",
     "node-fetch": "^2.6.1",
     "progress": "^2.0.3",
+    "properties": "^1.2.1",
     "read": "^1.0.7",
     "request": "^2.88.2",
     "tcp-ping": "^0.1.1",
-    "tty-table": "4.1",
+    "tty-table": "4.2",
-    "update-notifier": "^4.1.1",
+    "update-notifier": "^5.1.0",
     "yauzl": "^2.10.0",
     "yazl": "2.5.1"
   },
@@ -55,6 +55,11 @@
     "babel-plugin-transform-object-rest-spread": "^6.26.0"
   },
   "engines": {
-    "node": ">= 8"
+    "node": ">= 10"
+  },
+  "pnpm": {
+    "patchedDependencies": {
+      "app-info-parser@1.1.6": "patches/app-info-parser@1.1.6.patch"
+    }
   }
 }

patches/app-info-parser@1.1.6.patch

@@ -0,0 +1,17 @@
+diff --git a/src/xml-parser/binary.js b/src/xml-parser/binary.js
+index e20cc96e8131078ea81afeb31af46142a52da58e..f0f788cc555046f0dab47f8854f26344e0d5d714 100644
+--- a/src/xml-parser/binary.js
++++ b/src/xml-parser/binary.js
+@@ -547,8 +547,10 @@ var BinaryXmlParser = /*#__PURE__*/function () {
+       attr.nodeName = attr.name = this.strings[nameRef];
+       if (valueRef > 0) {
+         // some apk have versionName with special characters
+-        if (attr.name === 'versionName') {
+-          this.strings[valueRef] = this.strings[valueRef].replace(/[^\d\w-.]/g, '');
++        if (attr.name === 'versionName') {        
++          // only keep printable characters
++          // https://www.ascii-code.com/characters/printable-characters
++          this.strings[valueRef] = this.strings[valueRef].replace(/[^\x21-\x7E]/g, '')
+         }
+         attr.value = this.strings[valueRef];
+       }

src/api.js

@@ -1,17 +1,13 @@
-/**
+import fetch from 'node-fetch';
- * Created by tdzl2003 on 2/13/16.
+const defaultEndpoint = 'https://update.reactnative.cn/api';
- */
-
-const fetch = require('node-fetch');
-const defaultEndpoint = 'http://u.reactnative.cn/api';
 let host = process.env.PUSHY_REGISTRY || defaultEndpoint;
-const fs = require('fs');
+import fs from 'fs';
 import request from 'request';
 import ProgressBar from 'progress';
-const packageJson = require('../package.json');
+import packageJson from '../package.json';
-const tcpp = require('tcp-ping');
+import tcpp from 'tcp-ping';
-const util = require('util');
+import util from 'util';
-const path = require('path');
+import path from 'path';
 import filesizeParser from 'filesize-parser';
 import { pricingPageUrl } from './utils';
 
@@ -22,10 +18,18 @@ let savedSession = undefined;
 
 const userAgent = `react-native-update-cli/${packageJson.version}`;
 
-exports.loadSession = async function () {
+export const getSession = function () {
+  return session;
+};
+
+export const replaceSession = function (newSession) {
+  session = newSession;
+};
+
+export const loadSession = async function () {
   if (fs.existsSync('.update')) {
     try {
-      exports.replaceSession(JSON.parse(fs.readFileSync('.update', 'utf8')));
+      replaceSession(JSON.parse(fs.readFileSync('.update', 'utf8')));
       savedSession = session;
     } catch (e) {
       console.error(
@@ -36,15 +40,7 @@ exports.loadSession = async function () {
   }
 };
 
-exports.getSession = function () {
+export const saveSession = function () {
-  return session;
-};
-
-exports.replaceSession = function (newSession) {
-  session = newSession;
-};
-
-exports.saveSession = function () {
   // Only save on change.
   if (session !== savedSession) {
     const current = session;
@@ -54,7 +50,7 @@ exports.saveSession = function () {
   }
 };
 
-exports.closeSession = function () {
+export const closeSession = function () {
   if (fs.existsSync('.update')) {
     fs.unlinkSync('.update');
     savedSession = undefined;
@@ -65,7 +61,14 @@ exports.closeSession = function () {
 
 async function query(url, options) {
   const resp = await fetch(url, options);
-  const json = await resp.json();
+  const text = await resp.text();
+  let json;
+  try {
+    json = JSON.parse(text);
+  } catch (e) {
+    throw new Error(`Server error: ${text}`);
+  }
+
   if (resp.status !== 200) {
     throw Object.assign(new Error(json.message || json.error), {
       status: resp.status,
@@ -100,18 +103,21 @@ function queryWithBody(method) {
   };
 }
 
-exports.get = queryWithoutBody('GET');
+export const get = queryWithoutBody('GET');
-exports.post = queryWithBody('POST');
+export const post = queryWithBody('POST');
-exports.put = queryWithBody('PUT');
+export const put = queryWithBody('PUT');
-exports.doDelete = queryWithBody('DELETE');
+export const doDelete = queryWithBody('DELETE');
 
-async function uploadFile(fn, key) {
+export async function uploadFile(fn, key) {
-  const { url, backupUrl, formData, maxSize } = await exports.post('/upload', {
+  const { url, backupUrl, formData, maxSize } = await post('/upload', {
     ext: path.extname(fn),
   });
   let realUrl = url;
 
   if (backupUrl) {
+    if (global.USE_ACC_OSS) {
+      realUrl = backupUrl;
+    } else {
       const pingResult = await tcpPing({
         address: url.replace('https://', ''),
         attempts: 4,
@@ -121,6 +127,7 @@ async function uploadFile(fn, key) {
       if (isNaN(pingResult.avg) || pingResult.avg > 150) {
         realUrl = backupUrl;
       }
+    }
     // console.log({realUrl});
   }
 
@@ -129,11 +136,11 @@ async function uploadFile(fn, key) {
     throw new Error(
       `此文件大小${(fileSize / 1048576).toFixed(
         1,
-      )}m, 超出当前额度${maxSize}。您可以考虑升级付费业务以提升此额度。详情请访问：${pricingPageUrl}`,
+      )}m, 超出当前额度${maxSize}。您可以考虑升级付费业务以提升此额度。详情请访问: ${pricingPageUrl}`,
     );
   }
 
-  const bar = new ProgressBar('  Uploading [:bar] :percent :etas', {
+  const bar = new ProgressBar('  上传中 [:bar] :percent :etas', {
     complete: '=',
     incomplete: ' ',
     total: fileSize,
@@ -152,10 +159,6 @@ async function uploadFile(fn, key) {
       realUrl,
       {
         formData,
-        headers: {
-          'User-Agent': userAgent,
-          'X-AccessToken': session ? session.token : '',
-        },
       },
       (err, resp, body) => {
         if (err) {
@@ -166,17 +169,9 @@ async function uploadFile(fn, key) {
             Object.assign(new Error(body), { status: resp.statusCode }),
           );
         }
-        resolve(
+        resolve({ hash: formData.key });
-          body
-            ? // qiniu
-              JSON.parse(body)
-            : // aliyun oss
-              { hash: formData.key },
-        );
       },
     );
   });
   return info;
 }
-
-exports.uploadFile = uploadFile;

src/app.js

@@ -1,12 +1,8 @@
-/**
- * Created by tdzl2003 on 2/13/16.
- */
-
 import { question } from './utils';
 import fs from 'fs';
-const Table = require('tty-table');
+import Table from 'tty-table';
 
-const { post, get, doDelete } = require('./api');
+import { post, get, doDelete } from './api';
 
 const validPlatforms = {
   ios: 1,
@@ -15,7 +11,7 @@ const validPlatforms = {
 
 export function checkPlatform(platform) {
   if (!validPlatforms[platform]) {
-    throw new Error(`Invalid platform '${platform}'`);
+    throw new Error(`无法识别的平台 '${platform}'`);
   }
   return platform;
 }
@@ -42,9 +38,9 @@ export async function listApp(platform) {
   const list = platform ? data.filter((v) => v.platform === platform) : data;
 
   const header = [
-    { value: 'App Id' },
+    { value: '应用 id' },
-    { value: 'App Name' },
+    { value: '应用名称' },
-    { value: 'Platform' },
+    { value: '平台' },
   ];
   const rows = [];
   for (const app of list) {
@@ -54,9 +50,9 @@ export async function listApp(platform) {
   console.log(Table(header, rows).render());
 
   if (platform) {
-    console.log(`\nTotal ${list.length} ${platform} apps`);
+    console.log(`\共 ${list.length} ${platform} 个应用`);
   } else {
-    console.log(`\nTotal ${list.length} apps`);
+    console.log(`\共 ${list.length} 个应用`);
   }
   return list;
 }
@@ -65,7 +61,7 @@ export async function chooseApp(platform) {
   const list = await listApp(platform);
 
   while (true) {
-    const id = await question('Enter appId:');
+    const id = await question('输入应用 id:');
     const app = list.find((v) => v.id === (id | 0));
     if (app) {
       return app;
@@ -75,13 +71,13 @@ export async function chooseApp(platform) {
 
 export const commands = {
   createApp: async function ({ options }) {
-    const name = options.name || (await question('App Name:'));
+    const name = options.name || (await question('应用名称:'));
     const { downloadUrl } = options;
     const platform = checkPlatform(
-      options.platform || (await question('Platform(ios/android):')),
+      options.platform || (await question('平台(ios/android):')),
     );
     const { id } = await post('/app/create', { name, platform });
-    console.log(`Created app ${id}`);
+    console.log(`已成功创建应用（id: ${id}）`);
     await this.selectApp({
       args: [id],
       options: { platform, downloadUrl },
@@ -91,10 +87,10 @@ export const commands = {
     const { platform } = options;
     const id = args[0] || chooseApp(platform);
     if (!id) {
-      console.log('Canceled');
+      console.log('已取消');
     }
     await doDelete(`/app/${id}`);
-    console.log('Ok.');
+    console.log('操作成功');
   },
   apps: async function ({ options }) {
     const { platform } = options;
@@ -102,9 +98,9 @@ export const commands = {
   },
   selectApp: async function ({ args, options }) {
     const platform = checkPlatform(
-      options.platform || (await question('Platform(ios/android):')),
+      options.platform || (await question('平台(ios/android):')),
     );
-    const id = args[0] || (await chooseApp(platform)).id;
+    const id = args[0] ? parseInt(args[0]) : (await chooseApp(platform)).id;
 
     let updateInfo = {};
     if (fs.existsSync('update.json')) {

src/bundle.js

@@ -1,19 +1,16 @@
-/**
+import path from 'path';
- * Created by tdzl2003 on 2/22/16.
- */
-
-const path = require('path');
 import { getRNVersion, translateOptions } from './utils';
 import * as fs from 'fs-extra';
 import { ZipFile } from 'yazl';
 import { open as openZipFile } from 'yauzl';
 import { question, printVersionCommand } from './utils';
 import { checkPlatform } from './app';
-const { spawn, spawnSync } = require('child_process');
+import { spawn, spawnSync } from 'child_process';
 const g2js = require('gradle-to-js/lib/parser');
-const os = require('os');
+import os from 'os';
+const properties = require('properties');
 
-var bsdiff, hdiff, diff;
+let bsdiff, hdiff, diff;
 try {
   bsdiff = require('node-bsdiff').diff;
 } catch (e) {}
@@ -34,9 +31,11 @@ async function runReactNativeBundleCommand(
   let gradleConfig = {};
   if (platform === 'android') {
     gradleConfig = await checkGradleConfig();
-    // if (gradleConfig.crunchPngs !== false) {
+    if (gradleConfig.crunchPngs !== false) {
-    //   throw new Error('请先禁用android的crunchPngs优化，具体请参考 https://pushy.reactnative.cn/docs/getting-started.html#%E7%A6%81%E7%94%A8android%E7%9A%84crunch%E4%BC%98%E5%8C%96')
+      console.warn(
-    // }
+        'android的crunchPngs选项似乎尚未禁用（如已禁用则请忽略此提示），这可能导致热更包体积异常增大，具体请参考 https://pushy.reactnative.cn/docs/getting-started.html#%E7%A6%81%E7%94%A8-android-%E7%9A%84-crunch-%E4%BC%98%E5%8C%96 \n',
+      );
+    }
   }
 
   let reactNativeBundleArgs = [];
@@ -52,9 +51,27 @@ async function runReactNativeBundleCommand(
 
   fs.emptyDirSync(outputFolder);
 
+  let cliPath = require.resolve('react-native/local-cli/cli.js', {
+    paths: [process.cwd()],
+  });
+  try {
+    require.resolve('expo-router', {
+      paths: [process.cwd()],
+    });
+
+    console.log(`expo-router detected, will use @expo/cli to bundle.\n`);
+    // if using expo-router, use expo-cli
+    cliPath = require.resolve('@expo/cli', {
+      paths: [process.cwd()],
+    });
+  } catch (e) {}
+  const bundleCommand = cliPath.includes('@expo/cli')
+    ? 'export:embed'
+    : 'bundle';
+
   Array.prototype.push.apply(reactNativeBundleArgs, [
-    path.join('node_modules', 'react-native', 'local-cli', 'cli.js'),
+    cliPath,
-    'bundle',
+    bundleCommand,
     '--assets-dest',
     outputFolder,
     '--bundle-output',
@@ -98,8 +115,39 @@ async function runReactNativeBundleCommand(
           ),
         );
       } else {
-        if (gradleConfig.enableHermes) {
+        let hermesEnabled = false;
-          await compileHermesByteCode(bundleName, outputFolder);
+
+        if (platform === 'android') {
+          const gradlePropeties = await new Promise((resolve) => {
+            properties.parse(
+              './android/gradle.properties',
+              { path: true },
+              function (error, props) {
+                if (error) {
+                  console.error(error);
+                  resolve(null);
+                }
+
+                resolve(props);
+              },
+            );
+          });
+          hermesEnabled = gradlePropeties.hermesEnabled;
+
+          if (typeof hermesEnabled !== 'boolean')
+            hermesEnabled = gradleConfig.enableHermes;
+        } else if (
+          platform === 'ios' &&
+          fs.existsSync('ios/Pods/hermes-engine')
+        ) {
+          hermesEnabled = true;
+        }
+        if (hermesEnabled) {
+          await compileHermesByteCode(
+            bundleName,
+            outputFolder,
+            sourcemapOutput,
+          );
         }
         resolve(null);
       }
@@ -119,7 +167,6 @@ async function checkGradleConfig() {
   try {
     const gradleConfig = await g2js.parseFile('android/app/build.gradle');
     const projectConfig = gradleConfig['project.ext.react'];
-    crunchPngs = gradleConfig.android.buildTypes.release.crunchPngs;
     for (const packagerConfig of projectConfig) {
       if (
         packagerConfig.includes('enableHermes') &&
@@ -129,6 +176,7 @@ async function checkGradleConfig() {
         break;
       }
     }
+    crunchPngs = gradleConfig.android.buildTypes.release.crunchPngs;
   } catch (e) {}
   return {
     enableHermes,
@@ -136,35 +184,50 @@ async function checkGradleConfig() {
   };
 }
 
-async function compileHermesByteCode(bundleName, outputFolder) {
+async function compileHermesByteCode(
+  bundleName,
+  outputFolder,
+  sourcemapOutput,
+) {
   console.log(`Hermes enabled, now compiling to hermes bytecode:\n`);
-  const hermesPackage = fs.existsSync('node_modules/hermes-engine')
+  // >= rn 0.69
-    ? 'node_modules/hermes-engine' // 0.2+
+  const rnDir = path.dirname(
-    : 'node_modules/hermesvm'; // < 0.2
+    require.resolve('react-native', {
-  const hermesPath = `${hermesPackage}/${getHermesOSBin()}`;
+      paths: [process.cwd()],
+    }),
+  );
+  let hermesPath = path.join(rnDir, `/sdks/hermesc/${getHermesOSBin()}`);
 
-  const hermesCommand = fs.existsSync(`${hermesPath}/hermesc`)
+  // < rn 0.69
-    ? `${hermesPath}/hermesc` // 0.5+
+  if (!fs.existsSync(hermesPath)) {
-    : `${hermesPath}/hermes`; // < 0.5
+    hermesPath = `node_modules/hermes-engine/${getHermesOSBin()}`;
+  }
 
-  spawnSync(
+  const hermesCommand = `${hermesPath}/hermesc`;
-    path.join.apply(null, hermesCommand.split('/')),
+  
-    [
+  const args = [
     '-emit-binary',
     '-out',
     path.join(outputFolder, bundleName),
     path.join(outputFolder, bundleName),
     '-O',
-    ],
+  ];
-    { stdio: 'ignore' },
+  if (sourcemapOutput) {
+    args.push('-output-source-map');
+  }
+  console.log(
+    'Running hermesc: ' + hermesCommand + ' ' + args.join(' ') + '\n',
   );
+  spawnSync(hermesCommand, args, {
+    stdio: 'ignore',
+  });
 }
 
 async function pack(dir, output) {
   console.log('Packing');
   fs.ensureDirSync(path.dirname(output));
   await new Promise((resolve, reject) => {
-    var zipfile = new ZipFile();
+    const zipfile = new ZipFile();
 
     function addDirectory(root, rel) {
       if (rel) {
@@ -197,7 +260,7 @@ async function pack(dir, output) {
       });
     zipfile.end();
   });
-  console.log('Bundled saved to: ' + output);
+  console.log('ppk热更包已生成并保存到: ' + output);
 }
 
 function readEntire(entry, zipFile) {
@@ -254,7 +317,7 @@ async function diffFromPPK(origin, next, output) {
 
   const copies = {};
 
-  var zipfile = new ZipFile();
+  const zipfile = new ZipFile();
 
   const writePromise = new Promise((resolve, reject) => {
     zipfile.outputStream.on('error', (err) => {
@@ -339,7 +402,7 @@ async function diffFromPPK(origin, next, output) {
 
   const deletes = {};
 
-  for (var k in originEntries) {
+  for (let k in originEntries) {
     if (!newEntries[k]) {
       console.log('Delete ' + k);
       deletes[k] = 1;
@@ -396,7 +459,7 @@ async function diffFromPackage(
 
   const copies = {};
 
-  var zipfile = new ZipFile();
+  const zipfile = new ZipFile();
 
   const writePromise = new Promise((resolve, reject) => {
     zipfile.outputStream.on('error', (err) => {
@@ -515,22 +578,16 @@ function diffArgsCheck(args, options, diffFn) {
 export const commands = {
   bundle: async function ({ options }) {
     const platform = checkPlatform(
-      options.platform || (await question('Platform(ios/android):')),
+      options.platform || (await question('平台(ios/android):')),
     );
 
-    let {
+    let { bundleName, entryFile, intermediaDir, output, dev, sourcemap } =
-      bundleName,
+      translateOptions({
-      entryFile,
-      intermediaDir,
-      output,
-      dev,
-      verbose,
-    } = translateOptions({
         ...options,
         platform,
       });
 
-    // const sourcemapOutput = path.join(intermediaDir, bundleName + ".map");
+    const sourcemapOutput = path.join(intermediaDir, bundleName + '.map');
 
     const realOutput = output.replace(/\$\{time\}/g, '' + Date.now());
 
@@ -549,11 +606,12 @@ export const commands = {
       entryFile,
       intermediaDir,
       platform,
+      sourcemap ? sourcemapOutput : '',
     );
 
     await pack(path.resolve(intermediaDir), realOutput);
 
-    const v = await question('Would you like to publish it?(Y/N)');
+    const v = await question('是否现在上传此热更包?(Y/N)');
     if (v.toLowerCase() === 'y') {
       await this.publish({
         args: [realOutput],

src/index.js

@@ -1,21 +1,20 @@
 #!/usr/bin/env node
-/**
- * Created by tdzl2003 on 2/13/16.
- */
 
-const {loadSession} = require('./api');
+import { loadSession } from './api';
-const updateNotifier = require('update-notifier');
+import updateNotifier from 'update-notifier';
 import { printVersionCommand } from './utils/index.js';
-const pkg = require('../package.json');
+import pkg from '../package.json';
 
-updateNotifier({pkg}).notify({isGlobal: true});
+updateNotifier({ pkg }).notify({ isGlobal: true });
 
-function printUsage({args}) {
+function printUsage({ args }) {
   // const commandName = args[0];
   // TODO: print usage of commandName, or print global usage.
 
-  console.log('Usage is under development now.')
+  console.log('Usage is under development now.');
-  console.log('Visit `https://github.com/reactnativecn/react-native-pushy` for early document.');
+  console.log(
+    'Visit `https://github.com/reactnativecn/react-native-pushy` for early document.',
+  );
   process.exit(1);
 }
 
@@ -36,17 +35,18 @@ function run() {
 
   const argv = require('cli-arguments').parse(require('../cli.json'));
   global.NO_INTERACTIVE = argv.options['no-interactive'];
+  global.USE_ACC_OSS = argv.options['acc'];
 
   loadSession()
-    .then(()=>commands[argv.command](argv))
+    .then(() => commands[argv.command](argv))
-    .catch(err=>{
+    .catch((err) => {
       if (err.status === 401) {
-        console.log('Not loggined.\nRun `pushy login` at your project directory to login.');
+        console.log('尚未登录。\n请在项目目录中运行`pushy login`命令来登录');
         return;
       }
       console.error(err.stack);
       process.exit(-1);
     });
-};
+}
 
 run();

src/package.js

@@ -1,36 +1,37 @@
-/**
+import { get, post, uploadFile } from './api';
- * Created by tdzl2003 on 4/2/16.
- */
-
-const { get, post, uploadFile } = require('./api');
 import { question, saveToLocal } from './utils';
 
 import { checkPlatform, getSelectedApp } from './app';
 
 import { getApkInfo, getIpaInfo } from './utils';
-const Table = require('tty-table');
+import Table from 'tty-table';
 
 export async function listPackage(appId) {
   const { data } = await get(`/app/${appId}/package/list?limit=1000`);
 
-  const header = [{ value: 'Package Id' }, { value: 'Version' }];
+  const header = [{ value: '原生包 Id' }, { value: '原生版本' }];
   const rows = [];
   for (const pkg of data) {
     const { version } = pkg;
     let versionInfo = '';
     if (version) {
-      versionInfo = ` - ${version.id} ${version.hash.slice(0, 8)} ${
+      versionInfo = `, 已绑定：${version.name} (${version.id})`;
-        version.name
-      }`;
     } else {
-      versionInfo = ' (newest)';
+      // versionInfo = ' (newest)';
     }
-
+    let output = pkg.name;
-    rows.push([pkg.id, `${pkg.name}(${pkg.status})${versionInfo}`]);
+    if (pkg.status === 'paused') {
+      output += '(已暂停)';
+    }
+    if (pkg.status === 'expired') {
+      output += '(已过期)';
+    }
+    output += versionInfo;
+    rows.push([pkg.id, output]);
   }
 
   console.log(Table(header, rows).render());
-  console.log(`\nTotal ${data.length} package(s).`);
+  console.log(`\n共 ${data.length} 个包`);
   return data;
 }
 
@@ -38,7 +39,7 @@ export async function choosePackage(appId) {
   const list = await listPackage(appId);
 
   while (true) {
-    const id = await question('Enter Package Id:');
+    const id = await question('输入原生包 id:');
     const app = list.find((v) => v.id === (id | 0));
     if (app) {
       return app;
@@ -50,7 +51,7 @@ export const commands = {
   uploadIpa: async function ({ args }) {
     const fn = args[0];
     if (!fn || !fn.endsWith('.ipa')) {
-      throw new Error('Usage: pushy uploadIpa <ipaFile>');
+      throw new Error('使用方法: pushy uploadIpa ipa后缀文件');
     }
     const {
       versionName,
@@ -60,15 +61,15 @@ export const commands = {
     } = await getIpaInfo(fn);
     const { appId, appKey } = await getSelectedApp('ios');
 
-    if (appIdInPkg && appIdInPkg !== appId) {
+    if (appIdInPkg && appIdInPkg != appId) {
       throw new Error(
-        `appId不匹配！当前ipa：${appIdInPkg}, 当前update.json：${appId}`,
+        `appId不匹配！当前ipa: ${appIdInPkg}, 当前update.json: ${appId}`,
       );
     }
 
     if (appKeyInPkg && appKeyInPkg !== appKey) {
       throw new Error(
-        `appKey不匹配！当前ipa：${appKeyInPkg}, 当前update.json：${appKey}`,
+        `appKey不匹配！当前ipa: ${appKeyInPkg}, 当前update.json: ${appKey}`,
       );
     }
 
@@ -80,12 +81,14 @@ export const commands = {
       buildTime,
     });
     saveToLocal(fn, `${appId}/package/${id}.ipa`);
-    console.log(`Ipa uploaded: ${id}`);
+    console.log(
+      `已成功上传ipa原生包（id: ${id}, version: ${versionName}, buildTime: ${buildTime}）`,
+    );
   },
   uploadApk: async function ({ args }) {
     const fn = args[0];
     if (!fn || !fn.endsWith('.apk')) {
-      throw new Error('Usage: pushy uploadApk <apkFile>');
+      throw new Error('使用方法: pushy uploadApk apk后缀文件');
     }
     const {
       versionName,
@@ -95,15 +98,15 @@ export const commands = {
     } = await getApkInfo(fn);
     const { appId, appKey } = await getSelectedApp('android');
 
-    if (appIdInPkg && appIdInPkg !== appId) {
+    if (appIdInPkg && appIdInPkg != appId) {
       throw new Error(
-        `appId不匹配！当前apk：${appIdInPkg}, 当前update.json：${appId}`,
+        `appId不匹配！当前apk: ${appIdInPkg}, 当前update.json: ${appId}`,
       );
     }
 
     if (appKeyInPkg && appKeyInPkg !== appKey) {
       throw new Error(
-        `appKey不匹配！当前apk：${appKeyInPkg}, 当前update.json：${appKey}`,
+        `appKey不匹配！当前apk: ${appKeyInPkg}, 当前update.json: ${appKey}`,
       );
     }
 
@@ -115,25 +118,27 @@ export const commands = {
       buildTime,
     });
     saveToLocal(fn, `${appId}/package/${id}.apk`);
-    console.log(`Apk uploaded: ${id}`);
+    console.log(
+      `已成功上传apk原生包（id: ${id}, version: ${versionName}, buildTime: ${buildTime}）`,
+    );
   },
   parseIpa: async function ({ args }) {
     const fn = args[0];
     if (!fn || !fn.endsWith('.ipa')) {
-      throw new Error('Usage: pushy parseIpa <ipaFile>');
+      throw new Error('使用方法: pushy parseIpa ipa后缀文件');
     }
     console.log(await getIpaInfo(fn));
   },
   parseApk: async function ({ args }) {
     const fn = args[0];
     if (!fn || !fn.endsWith('.apk')) {
-      throw new Error('Usage: pushy parseApk <apkFile>');
+      throw new Error('使用方法: pushy parseApk apk后缀文件');
     }
     console.log(await getApkInfo(fn));
   },
   packages: async function ({ options }) {
     const platform = checkPlatform(
-      options.platform || (await question('Platform(ios/android):')),
+      options.platform || (await question('平台(ios/android):')),
     );
     const { appId } = await getSelectedApp(platform);
     await listPackage(appId);

src/user.js

@@ -1,38 +1,28 @@
-/**
+import { question } from './utils';
- * Created by tdzl2003 on 2/13/16.
+import { post, get, replaceSession, saveSession, closeSession } from './api';
- */
+import crypto from 'crypto';
-
-import {question} from './utils';
-const {
-  post,
-  get,
-  replaceSession,
-  saveSession,
-  closeSession,
-} = require('./api');
-const crypto = require('crypto');
 
 function md5(str) {
   return crypto.createHash('md5').update(str).digest('hex');
 }
 
-exports.commands = {
+export const commands = {
-  login: async function ({args}){
+  login: async function ({ args }) {
-    const email = args[0] || await question('email:');
+    const email = args[0] || (await question('email:'));
-    const pwd = args[1] || await question('password:', true);
+    const pwd = args[1] || (await question('password:', true));
-    const {token, info} = await post('/user/login', {
+    const { token, info } = await post('/user/login', {
       email,
       pwd: md5(pwd),
     });
-    replaceSession({token});
+    replaceSession({ token });
     await saveSession();
-    console.log(`Welcome, ${info.name}.`);
+    console.log(`欢迎使用 pushy 热更新服务， ${info.name}.`);
   },
-  logout: async function (){
+  logout: async function () {
     await closeSession();
-    console.log('Logged out.');
+    console.log('已退出登录');
   },
-  me: async function (){
+  me: async function () {
     const me = await get('/user/me');
     for (const k in me) {
       if (k !== 'ok') {
@@ -40,4 +30,4 @@ exports.commands = {
       }
     }
   },
-}
+};

src/utils/index.js

@@ -1,14 +1,10 @@
-/**
- * Created by tdzl2003 on 2/13/16.
- */
-
 import fs from 'fs-extra';
 import os from 'os';
 import path from 'path';
-const pkg = require('../../package.json');
+import pkg from '../../package.json';
-const AppInfoParser = require('app-info-parser');
+import AppInfoParser from 'app-info-parser';
 
-var read = require('read');
+import read from 'read';
 
 export function question(query, password) {
   if (NO_INTERACTIVE) {
@@ -43,7 +39,11 @@ export function translateOptions(options) {
 
 export function getRNVersion() {
   const version = JSON.parse(
-    fs.readFileSync(path.resolve('node_modules/react-native/package.json')),
+    fs.readFileSync(
+      require.resolve('react-native/package.json', {
+        paths: [process.cwd()],
+      }),
+    ),
   ).version;
 
   // We only care about major and minor version.
@@ -106,9 +106,8 @@ export async function getIpaInfo(fn) {
   if (updateJsonFile) {
     appCredential = JSON.parse(updateJsonFile.toString()).ios;
   }
-  const {
+  const { CFBundleShortVersionString: versionName } =
-    CFBundleShortVersionString: versionName,
+    await appInfoParser.parse();
-  } = await appInfoParser.parse();
   let buildTimeTxtBuffer = await appInfoParser.parser.getEntry(
     /payload\/.+?\.app\/pushy_build_time.txt/,
   );
@@ -139,11 +138,11 @@ export function saveToLocal(originPath, destName) {
 export function printVersionCommand() {
   console.log('react-native-update-cli: ' + pkg.version);
   try {
-    const PACKAGE_JSON_PATH = path.resolve(
+    const PACKAGE_JSON_PATH = require.resolve(
-      process.cwd(),
+      'react-native-update/package.json',
-      'node_modules',
+      {
-      'react-native-update',
+        paths: [process.cwd()],
-      'package.json',
+      },
     );
     console.log('react-native-update: ' + require(PACKAGE_JSON_PATH).version);
   } catch (e) {

src/versions.js

@@ -1,13 +1,4 @@
-/**
+import { get, post, put, uploadFile } from './api';
- * Created by tdzl2003 on 4/2/16.
- */
-
-const {
-  get,
-  post,
-  put,
-  uploadFile,
-} = require('./api');
 import { question, saveToLocal } from './utils';
 
 import { checkPlatform, getSelectedApp } from './app';
@@ -17,17 +8,24 @@ async function showVersion(appId, offset) {
   const { data, count } = await get(`/app/${appId}/version/list`);
   console.log(`Offset ${offset}`);
   for (const version of data) {
-    let packageInfo = version.packages.slice(0, 3).map(v=>v.name).join(', ');
+    let packageInfo = version.packages
+      .slice(0, 3)
+      .map((v) => v.name)
+      .join(', ');
     const count = version.packages.length;
     if (count > 3) {
-      packageInfo += `...and ${count-3} more`;
+      packageInfo += `...and ${count - 3} more`;
     }
     if (count === 0) {
       packageInfo = `(no package)`;
     } else {
       packageInfo = `[${packageInfo}]`;
     }
-    console.log(`${version.id}) ${version.hash.slice(0, 8)} ${version.name} ${packageInfo}`);
+    console.log(
+      `${version.id}) ${version.hash.slice(0, 8)} ${
+        version.name
+      } ${packageInfo}`,
+    );
   }
   return data;
 }
@@ -38,10 +36,17 @@ async function listVersions(appId) {
     await showVersion(appId, offset);
     const cmd = await question('page Up/page Down/Begin/Quit(U/D/B/Q)');
     switch (cmd.toLowerCase()) {
-      case 'u': offset = Math.max(0, offset - 10); break;
+      case 'u':
-      case 'd': offset += 10; break;
+        offset = Math.max(0, offset - 10);
-      case 'b': offset = 0; break;
+        break;
-      case 'q': return;
+      case 'd':
+        offset += 10;
+        break;
+      case 'b':
+        offset = 0;
+        break;
+      case 'q':
+        return;
     }
   }
 }
@@ -50,14 +55,21 @@ async function chooseVersion(appId) {
   let offset = 0;
   while (true) {
     const data = await showVersion(appId, offset);
-    const cmd = await question('Enter versionId or page Up/page Down/Begin(U/D/B)');
+    const cmd = await question(
+      'Enter versionId or page Up/page Down/Begin(U/D/B)',
+    );
     switch (cmd.toLowerCase()) {
-      case 'U': offset = Math.max(0, offset - 10); break;
+      case 'U':
-      case 'D': offset += 10; break;
+        offset = Math.max(0, offset - 10);
-      case 'B': offset = 0; break;
+        break;
-      default:
+      case 'D':
-      {
+        offset += 10;
-        const v = data.find(v=>v.id === (cmd | 0));
+        break;
+      case 'B':
+        offset = 0;
+        break;
+      default: {
+        const v = data.find((v) => v.id === (cmd | 0));
         if (v) {
           return v;
         }
@@ -67,47 +79,88 @@ async function chooseVersion(appId) {
 }
 
 export const commands = {
-  publish: async function({args, options}) {
+  publish: async function ({ args, options }) {
     const fn = args[0];
-    const {name, description, metaInfo } = options;
+    const { name, description, metaInfo } = options;
 
     if (!fn || !fn.endsWith('.ppk')) {
-      throw new Error('Usage: pushy publish <ppkFile> --platform ios|android');
+      throw new Error(
+        '使用方法: pushy publish ppk后缀文件 --platform ios|android',
+      );
     }
 
-    const platform = checkPlatform(options.platform || await question('Platform(ios/android):'));
+    const platform = checkPlatform(
+      options.platform || (await question('平台(ios/android):')),
+    );
     const { appId } = await getSelectedApp(platform);
 
     const { hash } = await uploadFile(fn);
 
     const { id } = await post(`/app/${appId}/version/create`, {
-      name: name || await question('Enter version name:') || '(未命名)',
+      name: name || (await question('输入版本名称: ')) || '(未命名)',
       hash,
-      description: description || await question('Enter description:'),
+      description: description || (await question('输入版本描述:')),
-      metaInfo: metaInfo || await question('Enter meta info:'),
+      metaInfo: metaInfo || (await question('输入自定义的 meta info:')),
     });
     // TODO local diff
     saveToLocal(fn, `${appId}/ppk/${id}.ppk`);
-    console.log(`Version published: ${id}`);
+    console.log(`已成功上传新热更包（id: ${id}）`);
 
-    const v = await question('Would you like to bind packages to this version?(Y/N)');
+    const v = await question('是否现在将此热更应用到原生包上？(Y/N)');
     if (v.toLowerCase() === 'y') {
-      await this.update({args:[], options:{versionId: id, platform}});
+      await this.update({ args: [], options: { versionId: id, platform } });
     }
   },
-  versions: async function({options}) {
+  versions: async function ({ options }) {
-    const platform = checkPlatform(options.platform || await question('Platform(ios/android):'));
+    const platform = checkPlatform(
+      options.platform || (await question('平台(ios/android):')),
+    );
     const { appId } = await getSelectedApp(platform);
     await listVersions(appId);
   },
-  update: async function({args, options}) {
+  update: async function ({ args, options }) {
-    const platform = checkPlatform(options.platform || await question('Platform(ios/android):'));
+    const platform = checkPlatform(
+      options.platform || (await question('平台(ios/android):')),
+    );
     const { appId } = await getSelectedApp(platform);
     const versionId = options.versionId || (await chooseVersion(appId)).id;
-    const pkgId = options.packageId || (await choosePackage(appId)).id;
+
+    let pkgId;
+    let pkgVersion = options.packageVersion;
+    if (pkgVersion) {
+      pkgVersion = pkgVersion.trim();
+      const { data } = await get(`/app/${appId}/package/list?limit=1000`);
+      const pkg = data.find((d) => d.name === pkgVersion);
+      if (pkg) {
+        pkgId = pkg.id;
+      } else {
+        throw new Error(`未查询到匹配原生版本：${pkgVersion}`);
+      }
+    }
+    if (!pkgId) {
+      pkgId = options.packageId || (await choosePackage(appId)).id;
+    }
+
+    if (!pkgId) {
+      throw new Error('请提供 packageId 或 packageVersion 参数');
+    }
     await put(`/app/${appId}/package/${pkgId}`, {
       versionId,
     });
-    console.log('Ok.');
+    console.log('操作成功');
-  }
+  },
+  updateVersionInfo: async function ({ args, options }) {
+    const platform = checkPlatform(
+      options.platform || (await question('平台(ios/android):')),
+    );
+    const { appId } = await getSelectedApp(platform);
+    const versionId = options.versionId || (await chooseVersion(appId)).id;
+
+    const updateParams = {};
+    options.name && (updateParams.name = options.name);
+    options.description && (updateParams.description = options.description);
+    options.metaInfo && (updateParams.metaInfo = options.metaInfo);
+    await put(`/app/${appId}/version/${versionId}`, updateParams);
+    console.log('操作成功');
+  },
 };